feat: add log settings to project settings #796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks promising, I want to take a few days to go through each part to make sure they all work. I think this also fixes #791 |
This was
linked to
issues
Apr 30, 2021
Closed
|
I'm going through this PR now. I want to make sure I understand what is going on before I merge it, and I'm probably going to try and simplify a few of the parts. I'm also added headers for the namespaces I'm hoping to get this all merged by the end of this week Edit: I'm also looking into a "Find All" button, we might be able to use reflection to find all class that have a |
|
This has been merged in as #951. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds log settings to the Unity project window and also greatly improving saving and loading.
It now uses a scriptable object saved in the ProjectSettings/com.miragenet.mirage folder, so now all users will have the same log settings.
This scriptable object is also moved into the assets folder on build and then removed afterward so it can be used at runtime.