Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lambda alarms and suggested config for it. #1517

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sveder
Copy link

@Sveder Sveder commented May 25, 2018

(Sveder: This is still a WIP. Opening PR to see that all tests pass in Travis. Leaving the instructions below to go over once the PR is done.)

Description

Added configuration for and the creation and deletion of cloudwatch alarms to Lambda and ApiGateway (WIP) automatically.

GitHub Issues

#1348

@Sveder
Copy link
Author

Sveder commented May 25, 2018

@Miserlou WIP, but I'd love pointers, especially on if you like the config additions (in example/zappa_settings.json).

Todos:

  1. Add cloudwatch alarms.
  2. Add docs about the new config.
  3. Add tests.

@coveralls
Copy link

coveralls commented May 26, 2018

Coverage Status

Coverage decreased (-0.3%) to 73.787% when pulling 54e3e61 on Sveder:'feature/cloudwatch_alarms' into 2d1f253 on Miserlou:master.

@Sveder
Copy link
Author

Sveder commented Jun 3, 2018

@Miserlou Any update on this?

@Miserlou
Copy link
Owner

Is this ready for review?

@Sveder
Copy link
Author

Sveder commented Jun 11, 2018

@Miserlou Do you want me to add unitests before you look at it? Or do you want to give me some general guidance and I'll add the changes with the unitests?

@mascot6699
Copy link

@Miserlou @Sveder I would like to take this up if we can have clear expectations set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants