Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dirty fix for request authorizers... #1535

Closed
wants to merge 8 commits into from
Closed

Dirty fix for request authorizers... #1535

wants to merge 8 commits into from

Commits on Jun 18, 2018

  1. Dirty fix for request authorizers... 

    Api gateway with a request authorizer must have an AuthorizationType value equal to 'CUSTOM' and not 'REQUEST'.
    @M0dM
    M0dM committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    ec15c5c View commit details
    Browse the repository at this point in the history

  2. Oops, I've done too much javascript those days...

    @M0dM
    M0dM committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    e047930 View commit details
    Browse the repository at this point in the history

  3. Fix Identity source default value. 

    Identity source isn't mandatory for request authorizers.
    @M0dM
    M0dM committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    bd335a6 View commit details
    Browse the repository at this point in the history

  4. Update core.py

    @M0dM
    M0dM committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    0acc3cc View commit details
    Browse the repository at this point in the history

  5. Forget my two previous commits... 

     IdentitySource is required, my bad...
    @M0dM
    M0dM committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    957327c View commit details
    Browse the repository at this point in the history

  6. Default value for idSource for request authorizer 

    IdentitySource is mandatory in troposphere...
Set context.identity.clientip by default seems to be a good workaround...
    @M0dM
    M0dM committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    e17d413 View commit details
    Browse the repository at this point in the history

  7. Fix default identity_source value

    @M0dM
    M0dM committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    456d1d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2018

  1. Fix Fix authorizer.get("type") call. 

    Fix authorizer.get("type") call when type hasn't been specified.
    @M0dM
    M0dM committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    6248de6 View commit details
    Browse the repository at this point in the history