Dirty fix for request authorizers... #1535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Api gateway with a request authorizer must have an AuthorizationType value equal to 'CUSTOM' and not 'REQUEST'.
Identity source isn't mandatory for request authorizers.
IdentitySource is required, my bad...
IdentitySource is mandatory in troposphere... Set context.identity.clientip by default seems to be a good workaround...
Fix authorizer.get("type") call when type hasn't been specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Api gateway with a request authorizer must have an AuthorizationType value equal to 'CUSTOM' and not 'REQUEST'.
Description
Support Request authorizer type with correct apu gateway authorizationType.
This is a dirty hack.
I am not very familiar with zappa's internal code.
Maybe this can/should be moved somewhere else in the code.
GitHub Issues
#1159