Switch middleware to avoid cookie packing, and use case mangling instead #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Extremely excited about this feature! Out with the old hacks, in with the new ones. Any chance you can repeal and replace the tests for this? Should actually increase overall coverage. It'd be great if you could also throw in some docstrings to the functions explaining what's happening here, and refer back to that pretty code you found on SO for proper attribution as well. 😸 |
|
I can confirm that it's working. Getting multiple 'set-cookie' headers back. Whohoo! |
|
BTW, used a django app to test this. |
|
Just tested it with my django project, works perfectly :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By mangling the case of the 'Set-Cookie' header, API Gateway will retain them all and include them as 'set-cookie' headers. This replaces the cookie packing which had issues with strict cookie parsers.