This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2019 into feature/reorganize
christopher-o-toole
suggested changes
Feb 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally you should document each file with a docstring but I'll let it slide for now given our schedule. The documentation and use of constants was a bit inconsistent in some areas as well. Other than that, the majority of the code looked alright.
Chris, I will add docstrings for each file to the Trello todo list. |
ClayMav
suggested changes
Feb 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_scripts
should not exist, and its contents should be inunit_tests
.- There should be no need for an
__init__.py
in the root directory. - There are no configuration parameters in the flightconfig.py, I would figure at least a few things should be configurable from flight to flight.
I don't think theres anything I really want to nitpick in the code here.
christopher-o-toole
previously approved these changes
Feb 7, 2019
ClayMav
approved these changes
Feb 7, 2019
…eature/reorganize
christopher-o-toole
approved these changes
Feb 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the reorganize of the flight code according to Clay's diagram. During the process of reorganizing, I changed certain aspects of the flight code. Of note:
drone._vehicle.rangerfinder.distance
and new code can dodrone.rangefinder.distance
.This is a big one, but I'm hoping we can get done by the flight test this weekend.