Fix opam init menu default

Follow up/fix to ocaml#5456

master_changes.md

@@ -32,7 +32,7 @@ users)
   * [BUG] Fix display of pinned packages in action list [#5079 @rjbou]
   * [BUG] Fix spaces in root and switch dirs [#5203 @jonahbeckford]
   * Use menu for init setup [#5057 @AltGr; #5217 @dra27]
-    * ✘ Change default from no to yes for shell update [#5456 @rjbou]
+    * ✘ Change default from no to yes for shell update [#5456 #5540 @rjbou @kit-ty-kate]
   * Do not show --yes and --no as special global options when using cmdliner >= 1.1 [#5269 @kit-ty-kate]
   * ◈ Add `tree` subcommand to display a dependency tree of currently installed packages [#5171 @cannorin - fix #3775]
   * ◈ `tree` subcommand now supports `--json` option [#5303 @cannorin - fix #5298]

src/state/opamEnv.ml

@@ -923,7 +923,7 @@ let setup
         match
           OpamConsole.menu "Do you want opam to configure %s?"
             (OpamConsole.colorise `bold (string_of_shell shell))
-            ~default ~no:`Yes ~options:[
+            ~default ~no:`No ~options:[
               `Yes, Printf.sprintf "Yes, update %s"
                 (OpamConsole.colorise `cyan (OpamFilename.prettify dot_profile));
               `No_hooks, Printf.sprintf "Yes, but don't setup any hooks. You'll \
@@ -961,7 +961,7 @@ let setup
       let default = match env_hook with
         | Some true -> `Yes
         | Some false -> `No_hooks
-        | None -> `No
+        | None -> `Yes
       in
       menu shell dot_profile default
   in