Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: change shell setup defaut to true #5456

Merged
merged 2 commits into from May 8, 2023

Conversation

rjbou
Copy link
Collaborator

@rjbou rjbou commented Feb 28, 2023

It's less confusing for newcomers.

@rjbou rjbou added the AREA: UI label Feb 28, 2023
@rjbou rjbou added this to the 2.2.0~alpha milestone Feb 28, 2023
@rjbou rjbou added this to PR in progress in Opam 2.2.0 via automation Feb 28, 2023
@kit-ty-kate kit-ty-kate linked an issue Feb 28, 2023 that may be closed by this pull request
@kit-ty-kate
Copy link
Member

Should we also do the suggestions from #5401 (comment) at the same time or leave it for later?

@rjbou rjbou added the PR: WIP Not for merge at this stage label Feb 28, 2023
@rjbou
Copy link
Collaborator Author

rjbou commented Feb 28, 2023

let's add them here, to have a complete PR

@kit-ty-kate kit-ty-kate self-assigned this Mar 14, 2023
@rjbou rjbou moved this from PR in progress to PR to update for 2.2.0~alpha in Opam 2.2.0 Mar 15, 2023
@kit-ty-kate kit-ty-kate removed the PR: WIP Not for merge at this stage label Apr 17, 2023
@kit-ty-kate kit-ty-kate moved this from PR to update for 2.2.0~alpha to PR to review for 2.2.0~alpha in Opam 2.2.0 Apr 17, 2023
@rjbou
Copy link
Collaborator Author

rjbou commented Apr 24, 2023

I can't approve as i opened the PR :) lgtm! thanks

@rjbou rjbou moved this from PR to review for 2.2.0~alpha to PR finalised (merge with CI) in Opam 2.2.0 Apr 24, 2023
@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit 5ef6c41 into ocaml:master May 8, 2023
27 checks passed
Opam 2.2.0 automation moved this from PR finalised (merge with CI) to Done May 8, 2023
kit-ty-kate added a commit to kit-ty-kate/opam that referenced this pull request May 8, 2023
kit-ty-kate added a commit to kit-ty-kate/opam that referenced this pull request May 8, 2023
MisterDA pushed a commit to MisterDA/opam that referenced this pull request May 23, 2023
rjbou pushed a commit to rjbou/opam that referenced this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Opam 2.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Change default to auto-install hooks on *nix
2 participants