v1.17.3 (#137)

* Fix custom metadata (Fixes #134) * Allow nexus-test subdomain (Fixes #136 * Update deps
MisterPhilip · Feb 8, 2021 · 1387da6 · 1387da6
1 parent 78dc893
commit 1387da6
Show file tree

Hide file tree

Showing 6 changed files with 947 additions and 1,031 deletions.
diff --git a/Gruntfile.js b/Gruntfile.js
@@ -14,19 +14,19 @@ module.exports = function (grunt) {
             },
             "production": {
                 "name": "Omnibug",
-                "version": "1.17.2",
+                "version": "1.17.3",
                 "storageKey": "omnibug",
                 "feedbackUrl": "https://github.com/MisterPhilip/omnibug/issues",
                 "analyticsID": "UA-114343677-2"
             }
         },
         "chrome": {
             "folder": "chromium",
-            "tracking": true
+            "tracking": false
         },
         "edge": {
             "folder": "edge",
-            "tracking": true
+            "tracking": false
         },
         "firefox": {
             "gecko": "Omnibug@rosssimpson.com",

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "omnibug",
-    "version": "1.17.2",
+    "version": "1.17.3",
     "description": "Omnibug Extension",
     "main": "Gruntfile.js",
     "scripts": {

diff --git a/src/providers/AdobeHeartbeat.js b/src/providers/AdobeHeartbeat.js
@@ -443,9 +443,9 @@ class AdobeHeartbeatProvider extends BaseProvider
         if(/^customMetadata\./i.test(name)) {
             result = {
                 "key":   name,
-                "field": "prop" + RegExp.$1,
+                "field": name.replace(/^customMetadata\./i, ""),
                 "value": value,
-                "group": "props"
+                "group": "customMetadata"
             };
         } else if(/^params\.analytics\./i.test(name) && !(name in this.keys)) {
             result = {

diff --git a/src/providers/EnsightenManage.js b/src/providers/EnsightenManage.js
@@ -11,7 +11,7 @@ class EnsightenManageProvider extends BaseProvider
     {
         super();
         this._key        = "ENSIGHTENMANAGE";
-        this._pattern    = /nexus\.ensighten\.com\/(?=.*Bootstrap\.js)/;
+        this._pattern    = /nexus(?:-test)?\.ensighten\.com\/(?=.*Bootstrap\.js)/;
         this._name       = "Ensighten Manage";
         this._type       = "tagmanager";
         this._keywords   = ["tms"];
@@ -80,4 +80,4 @@ class EnsightenManageProvider extends BaseProvider
 
         return results;
     }
-}
+}
diff --git a/test/providers/EnsightenManage.js b/test/providers/EnsightenManage.js
@@ -15,11 +15,14 @@ test("EnsightenManageProvider pattern should match Ensighten calls", t => {
     let provider = new EnsightenManageProvider(),
         urls = [
             "https://nexus.ensighten.com/omnibug/Bootstrap.js",
+            "https://nexus-test.ensighten.com/omnibug/Bootstrap.js",
             "https://nexus.ensighten.com/omnibug/OmnibugProd/Bootstrap.js",
-            "https://nexus.ensighten.com/omnibug/OmnibugProd/Bootstrap.js?cacheBuster=1234"
+            "https://nexus.ensighten.com/omnibug/OmnibugProd/Bootstrap.js?cacheBuster=1234",
+            "https://nexus-test.ensighten.com/omnibug/OmnibugProd/Bootstrap.js?cacheBuster=1234"
         ],
         badUrls = [
             "https://nexus.ensighten.com/omnibug/OmnibugProd/serverComponent.php",
+            "https://dummy-domain.ensighten.com/omnibug/OmnibugProd/Bootstrap.js",
             "https://nexus.ensighten.com/omnibug/OmnibugProd/code/123456789.js?conditionId0=123456"
         ];
 
@@ -67,4 +70,4 @@ test("EnsightenManageProvider returns profile when missing", t => {
 
     t.is(typeof profile, "object");
     t.is(profile.value, "prod");
-});
+});