Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensighten: not matched (self-hosted and/or nexus-test.ensighten.com) #136

Closed
allankronmark opened this issue Jan 14, 2021 · 3 comments · Fixed by #137
Closed

Ensighten: not matched (self-hosted and/or nexus-test.ensighten.com) #136

allankronmark opened this issue Jan 14, 2021 · 3 comments · Fixed by #137
Assignees
Labels
bug provider Relates to a provider/marketing tool

Comments

@allankronmark
Copy link

Describe the bug
When testing Ensighten (e.g. via Charles Proxy), hostname is rewritten to nexus-test.ensighten.com.

Additionally, the Bootstrap.js can be self-hosted (or otherwise served from the parent domain, e.g. via DNS magic).

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.dr.dk
  2. Open the chrome developer console and Inspect the network.
  3. Note Bootstrapper.js request URL.
  4. Compare with omnibug.

Expected behavior
The pattern for matching the Bootstrapper.js needs to take into account self-hosted.
Additionally, a regex pattern might be needed in order to match requests going to either nexus.ensighten.com OR nexus-test.ensighten.com.

@MisterPhilip
Copy link
Owner

Self-hosted files have been my nemesis for Omnibug, unfortunately. The problem is if you can rename the file, or the file is generically named (bootstrap.js is pretty generic), we run into false positives rather than false negatives.

I can definitely update for nexus.ensignten vs nexus-test.ensighten, but let me chew on the self-hosted part a little more.

@MisterPhilip MisterPhilip self-assigned this Jan 19, 2021
@MisterPhilip MisterPhilip added the provider Relates to a provider/marketing tool label Jan 19, 2021
@allankronmark
Copy link
Author

allankronmark commented Jan 20, 2021 via email

@MisterPhilip MisterPhilip mentioned this issue Feb 8, 2021
MisterPhilip added a commit that referenced this issue Feb 8, 2021
* Fix custom metadata (Fixes #134)
* Allow nexus-test subdomain (Fixes #136 
* Update deps
@MisterPhilip
Copy link
Owner

Sorry this took so long - but it is in the process of being released across all browsers (give it a few days usually). Given that the Bootstrap framework uses bootstrap.js as their file name (the non-minified version) and the popularity of that framework, I don't think we'll be able to reliably capture self-hosted files unfortunately :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug provider Relates to a provider/marketing tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants