-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensighten: not matched (self-hosted and/or nexus-test.ensighten.com) #136
Comments
Self-hosted files have been my nemesis for Omnibug, unfortunately. The problem is if you can rename the file, or the file is generically named (bootstrap.js is pretty generic), we run into false positives rather than false negatives. I can definitely update for nexus.ensignten vs nexus-test.ensighten, but let me chew on the self-hosted part a little more. |
To my knowledge they are always identified by the filename Bootstrapper.js - only the publish path is different.
A possible future feature could be to allow users to add their own patterns for matching.
Anyway, I think you’ve created a superb tool -I really appreciate it :)
… Den 19. jan. 2021 kl. 17.34 skrev Philip Lawrence ***@***.***>:
Self-hosted files have been my nemesis for Omnibug, unfortunately. The problem is if you can rename the file, or the file is generically named (bootstrap.js is pretty generic), we run into false positives rather than false negatives.
I can definitely update for nexus.ensignten vs nexus-test.ensighten, but let me chew on the self-hosted part a little more.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sorry this took so long - but it is in the process of being released across all browsers (give it a few days usually). Given that the Bootstrap framework uses bootstrap.js as their file name (the non-minified version) and the popularity of that framework, I don't think we'll be able to reliably capture self-hosted files unfortunately :( |
Describe the bug
When testing Ensighten (e.g. via Charles Proxy), hostname is rewritten to nexus-test.ensighten.com.
Additionally, the Bootstrap.js can be self-hosted (or otherwise served from the parent domain, e.g. via DNS magic).
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The pattern for matching the Bootstrapper.js needs to take into account self-hosted.
Additionally, a regex pattern might be needed in order to match requests going to either nexus.ensighten.com OR nexus-test.ensighten.com.
The text was updated successfully, but these errors were encountered: