Fix test failures that started appearing in CI #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this double-close occurs, an STFATAL is hit in UnixSocketHandler since the socket is already closed. To fix, if `destroyPartialConnection` is called don't call `close`, since `destroyPartialConnection` already closes the socket.
If the environment sets XDG_RUNTIME_DIR the test behavior changes and fails a check. Unset the env var before running the test.
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
==========================================
- Coverage 71.34% 71.30% -0.04%
==========================================
Files 49 49
Lines 3050 3074 +24
==========================================
+ Hits 2176 2192 +16
- Misses 874 882 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix failures likely from CI environment and timing changes
Fix a double-socket-close in ServerConnection, which triggers an STFATAL in UnixSocketHandler, which was showing up on the flaky socket tests. To fix, if
destroyPartialConnectionis called don't callclose, sincedestroyPartialConnectionalready closes the socket.Unset XDG_RUNTIME_DIR before running tests, since it changes the test behavior, and this appears to now be set by the CI system.
Disable ServerFifoPath tests when run as root, since the creation behavior it is testing is disabled as root, and it leads to a REQUIRE failure.