Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures that started appearing in CI #526

Merged
merged 3 commits into from
Jul 3, 2022
Merged

Fix test failures that started appearing in CI #526

merged 3 commits into from
Jul 3, 2022

Commits on Jul 1, 2022

  1. Fix double-socket-close in ServerConnection 

    When this double-close occurs, an STFATAL is hit in UnixSocketHandler
since the socket is already closed.

To fix, if `destroyPartialConnection` is called don't call `close`,
since `destroyPartialConnection` already closes the socket.
    @jwmcglynn
    jwmcglynn committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    700ab51 View commit details
    Browse the repository at this point in the history

  2. Disable ServerFifoPath tests when run as root

    @jwmcglynn
    jwmcglynn committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    74b423d View commit details
    Browse the repository at this point in the history

  3. Unset XDG_RUNTIME_DIR before running tests 

    If the environment sets XDG_RUNTIME_DIR the test behavior changes and
fails a check.

Unset the env var before running the test.
    @jwmcglynn
    jwmcglynn committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    38489cb View commit details
    Browse the repository at this point in the history