SSH config file parser #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterTea
requested changes
Sep 28, 2017
terminal/TerminalClient.cpp
Outdated
| /* First parse user-specific ssh config, then system-wide config. */ | ||
| parse_ssh_config_file(&options, string(home_dir) + "/.ssh/config"); | ||
| parse_ssh_config_file(&options, "/etc/ssh/ssh_config"); | ||
| cout << "connecting to " << options.host << endl; |
There was a problem hiding this comment.
Change to LOG(INFO). If we want to print to cout, that's fine but let's also add a LOG(INFO) line so it gets logged to file as well.
|
Fixed :) There are also some cout for error message before exiting in ParseConfigFile.hpp. I feel it's good to output sth before exiting, let me know if you would like them to be logged as well. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support parsing ssh config files for et to use. User-specific config file(~/.ssh/config) has higher priority than system-wide config file(/etc/ssh/ssh_config).
Currently these options below are parsed. Hostname field is used to help translate et host field.
For example, if you have a hostname alias
devforsomeremotemachine.com. you can now doet dev:8080instead ofet someremotemachine.com:8080.Support for other config options can be added based on request(such as jumphost).