Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

et fails to build on macOS mojave 10.14.6 #14

Closed
sqeeezy opened this issue Aug 7, 2021 · 10 comments
Closed

et fails to build on macOS mojave 10.14.6 #14

sqeeezy opened this issue Aug 7, 2021 · 10 comments

Comments

@sqeeezy
Copy link

sqeeezy commented Aug 7, 2021

Trying to install with Homebrew fails twice at the same point.

`/Users/nik:brew install et
==> Installing et from mistertea/et
==> Downloading https://github.com/MisterTea/EternalTerminal/archive/et-v6.1.8.tar.gz
Already downloaded: /Users/nik/Library/Caches/Homebrew/downloads/a3a27ae31ad58c94906e7f7491baadeb40a4e0e6c26665390a69129bcb5637ba--EternalTerminal-et-v6.1.8.tar.gz
==> cmake . -DDISABLE_VCPKG:BOOL=ON
==> make -j4 install
Last 15 lines from /Users/nik/Library/Logs/Homebrew/et/02.make:
[ 52%] Building CXX object CMakeFiles/et-lib.dir/src/base/DaemonCreator.cpp.o
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DET_VERSION="6.1.8" -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/easyloggingpp/src -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/ThreadPool -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/PlatformFolders -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/Catch2/single_include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/cxxopts/include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/msgpack-c/include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/sentry-native/include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/json/single_include/nlohmann -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/sole -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/base64 -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/simpleini -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/cpp-httplib -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/base -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/terminal -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/terminal/forwarding -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/htm -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8 -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/UniversalStacktrace/ust -DUSE_SENTRY -DELPP_NO_DEFAULT_LOG_FILE -DELPP_FEATURE_CRASH_LOG -DELPP_THREAD_SAFE -DSENTRY_BUILD_STATIC -g -ggdb3 -O3 -DNDEBUG -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk -include /tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/cotire/et-lib_CXX_prefix.hxx -std=gnu++17 -MD -MT CMakeFiles/et-lib.dir/src/base/DaemonCreator.cpp.o -MF CMakeFiles/et-lib.dir/src/base/DaemonCreator.cpp.o.d -o CMakeFiles/et-lib.dir/src/base/DaemonCreator.cpp.o -c /tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/base/DaemonCreator.cpp
[ 52%] Building CXX object CMakeFiles/et-lib.dir/src/base/RawSocketUtils.cpp.o
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DET_VERSION="6.1.8" -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/easyloggingpp/src -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/ThreadPool -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/PlatformFolders -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/Catch2/single_include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/cxxopts/include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/msgpack-c/include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/sentry-native/include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/json/single_include/nlohmann -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/sole -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/base64 -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/simpleini -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/cpp-httplib -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/base -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/terminal -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/terminal/forwarding -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/htm -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8 -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/UniversalStacktrace/ust -DUSE_SENTRY -DELPP_NO_DEFAULT_LOG_FILE -DELPP_FEATURE_CRASH_LOG -DELPP_THREAD_SAFE -DSENTRY_BUILD_STATIC -g -ggdb3 -O3 -DNDEBUG -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk -include /tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/cotire/et-lib_CXX_prefix.hxx -std=gnu++17 -MD -MT CMakeFiles/et-lib.dir/src/base/RawSocketUtils.cpp.o -MF CMakeFiles/et-lib.dir/src/base/RawSocketUtils.cpp.o.d -o CMakeFiles/et-lib.dir/src/base/RawSocketUtils.cpp.o -c /tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/base/RawSocketUtils.cpp
[ 52%] Building CXX object CMakeFiles/et-lib.dir/src/base/SubprocessToString.cpp.o
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DET_VERSION="6.1.8" -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/easyloggingpp/src -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/ThreadPool -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/PlatformFolders -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/Catch2/single_include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/cxxopts/include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/msgpack-c/include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/sentry-native/include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/json/single_include/nlohmann -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/sole -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/base64 -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/simpleini -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/cpp-httplib -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/base -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/terminal -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/terminal/forwarding -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/htm -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8 -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/UniversalStacktrace/ust -DUSE_SENTRY -DELPP_NO_DEFAULT_LOG_FILE -DELPP_FEATURE_CRASH_LOG -DELPP_THREAD_SAFE -DSENTRY_BUILD_STATIC -g -ggdb3 -O3 -DNDEBUG -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk -include /tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/cotire/et-lib_CXX_prefix.hxx -std=gnu++17 -MD -MT CMakeFiles/et-lib.dir/src/base/SubprocessToString.cpp.o -MF CMakeFiles/et-lib.dir/src/base/SubprocessToString.cpp.o.d -o CMakeFiles/et-lib.dir/src/base/SubprocessToString.cpp.o -c /tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/base/SubprocessToString.cpp
[ 54%] Building CXX object CMakeFiles/et-lib.dir/ET.pb.cc.o
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DET_VERSION="6.1.8" -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/easyloggingpp/src -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/ThreadPool -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/PlatformFolders -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/Catch2/single_include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/cxxopts/include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/msgpack-c/include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/sentry-native/include -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/json/single_include/nlohmann -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/sole -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/base64 -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/simpleini -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/cpp-httplib -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/base -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/terminal -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/terminal/forwarding -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/src/htm -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8 -I/tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/external_imported/UniversalStacktrace/ust -DUSE_SENTRY -DELPP_NO_DEFAULT_LOG_FILE -DELPP_FEATURE_CRASH_LOG -DELPP_THREAD_SAFE -DSENTRY_BUILD_STATIC -g -ggdb3 -O3 -DNDEBUG -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk -include /tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/cotire/et-lib_CXX_prefix.hxx -std=gnu++17 -MD -MT CMakeFiles/et-lib.dir/ET.pb.cc.o -MF CMakeFiles/et-lib.dir/ET.pb.cc.o.d -o CMakeFiles/et-lib.dir/ET.pb.cc.o -c /tmp/et-20210807-2100-i54j3b/EternalTerminal-et-v6.1.8/ET.pb.cc
[ 54%] Linking CXX static library libet-lib.a
/usr/local/Cellar/cmake/3.21.1/bin/cmake -P CMakeFiles/et-lib.dir/cmake_clean_target.cmake
/usr/local/Cellar/cmake/3.21.1/bin/cmake -E cmake_link_script CMakeFiles/et-lib.dir/link.txt --verbose=1
/usr/bin/ar qc libet-lib.a CMakeFiles/et-lib.dir/external_imported/easyloggingpp/src/easylogging++.cc.o CMakeFiles/et-lib.dir/external_imported/PlatformFolders/sago/platform_folders.cpp.o CMakeFiles/et-lib.dir/src/base/BackedReader.cpp.o CMakeFiles/et-lib.dir/src/base/BackedWriter.cpp.o CMakeFiles/et-lib.dir/src/base/ClientConnection.cpp.o CMakeFiles/et-lib.dir/src/base/Connection.cpp.o CMakeFiles/et-lib.dir/src/base/CryptoHandler.cpp.o CMakeFiles/et-lib.dir/src/base/ServerClientConnection.cpp.o CMakeFiles/et-lib.dir/src/base/ServerConnection.cpp.o CMakeFiles/et-lib.dir/src/base/SocketHandler.cpp.o CMakeFiles/et-lib.dir/src/base/PipeSocketHandler.cpp.o CMakeFiles/et-lib.dir/src/base/TcpSocketHandler.cpp.o CMakeFiles/et-lib.dir/src/base/UnixSocketHandler.cpp.o CMakeFiles/et-lib.dir/src/base/LogHandler.cpp.o CMakeFiles/et-lib.dir/src/base/DaemonCreator.cpp.o CMakeFiles/et-lib.dir/src/base/RawSocketUtils.cpp.o CMakeFiles/et-lib.dir/src/base/SubprocessToString.cpp.o CMakeFiles/et-lib.dir/ET.pb.cc.o
/usr/bin/ranlib libet-lib.a
[ 54%] Built target et-lib
make: *** [all] Error 2

If reporting this issue please do so at (not Homebrew/brew or Homebrew/core):
https://github.com/mistertea/homebrew-et/issues

/Users/nik:et nik@vp64.local
fish: Unknown command: et
`
@mattypiper mattypiper mentioned this issue Aug 11, 2021
Closed
@dgentry
Copy link

dgentry commented Aug 29, 2021

I think the actual error is here (in the above log, it doesn't occur in the last 15 lines because other make threads finish later):

[ 45%] Building CXX object CMakeFiles/et-lib.dir/src/base/SocketHandler.cpp.o
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DET_VERSION=\"6.1.8\" -I/tmp/et-2
0210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/easyloggingpp/src -I/tmp/et-20210828-18195-1ecm1bw/EternalTermin
al-et-v6.1.8/external_imported/ThreadPool -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/PlatformFol
ders -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/Catch2/single_include -I/tmp/et-20210828-18195-1
ecm1bw/EternalTerminal-et-v6.1.8/external_imported/cxxopts/include -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/exte
rnal_imported/msgpack-c/include -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/sentry-native/include
 -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/json/single_include/nlohmann -I/tmp/et-20210828-1819
5-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/sole -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imp
orted/base64 -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/simpleini -I/tmp/et-20210828-18195-1ecm1
bw/EternalTerminal-et-v6.1.8/external_imported/cpp-httplib -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/src/base -I/
tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/src/terminal -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/sr
c/terminal/forwarding -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/src/htm -I/tmp/et-20210828-18195-1ecm1bw/EternalT
erminal-et-v6.1.8 -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/UniversalStacktrace/ust -DUSE_SENTR
Y -DELPP_NO_DEFAULT_LOG_FILE -DELPP_FEATURE_CRASH_LOG -DELPP_THREAD_SAFE -DSENTRY_BUILD_STATIC -g -ggdb3 -O3 -DNDEBUG -isysroot /L
ibrary/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk -include /tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/cotire/et
-lib_CXX_prefix.hxx -std=gnu++17 -MD -MT CMakeFiles/et-lib.dir/src/base/SocketHandler.cpp.o -MF CMakeFiles/et-lib.dir/src/base/Soc
ketHandler.cpp.o.d -o CMakeFiles/et-lib.dir/src/base/SocketHandler.cpp.o -c /tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1
.8/src/base/SocketHandler.cpp
/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/src/terminal/TelemetryService.cpp:98:21: error: 'exists' is unavailable:
introduced in macOS 10.15
    if (filesystem::exists(telemetryConfigPath)) {
                    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:1617:39: note:
 'exists' has been explicitly marked unavailable here
inline _LIBCPP_INLINE_VISIBILITY bool exists(const path& __p) {
                                      ^
/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/src/terminal/TelemetryService.cpp:98:28: error: 'path' is unavailable: in
troduced in macOS 10.15
    if (filesystem::exists(telemetryConfigPath)) {
                           ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:773:3: note: '
path' has been explicitly marked unavailable here
  path(const _Source& __src, format = format::auto_format) {
  ^
/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/src/terminal/TelemetryService.cpp:98:28: error: '~path' is unavailable: i
ntroduced in macOS 10.15
    if (filesystem::exists(telemetryConfigPath)) {
                           ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:791:3: note: '
~path' has been explicitly marked unavailable here
  ~path() = default;

@sqeeezy
Copy link
Author

sqeeezy commented Aug 29, 2021

I think the actual error is here (in the above log, it doesn't occur in the last 15 lines because other make threads finish later):

[ 45%] Building CXX object CMakeFiles/et-lib.dir/src/base/SocketHandler.cpp.o
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DET_VERSION=\"6.1.8\" -I/tmp/et-2
0210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/easyloggingpp/src -I/tmp/et-20210828-18195-1ecm1bw/EternalTermin
al-et-v6.1.8/external_imported/ThreadPool -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/PlatformFol
ders -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/Catch2/single_include -I/tmp/et-20210828-18195-1
ecm1bw/EternalTerminal-et-v6.1.8/external_imported/cxxopts/include -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/exte
rnal_imported/msgpack-c/include -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/sentry-native/include
 -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/json/single_include/nlohmann -I/tmp/et-20210828-1819
5-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/sole -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imp
orted/base64 -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/simpleini -I/tmp/et-20210828-18195-1ecm1
bw/EternalTerminal-et-v6.1.8/external_imported/cpp-httplib -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/src/base -I/
tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/src/terminal -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/sr
c/terminal/forwarding -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/src/htm -I/tmp/et-20210828-18195-1ecm1bw/EternalT
erminal-et-v6.1.8 -I/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/external_imported/UniversalStacktrace/ust -DUSE_SENTR
Y -DELPP_NO_DEFAULT_LOG_FILE -DELPP_FEATURE_CRASH_LOG -DELPP_THREAD_SAFE -DSENTRY_BUILD_STATIC -g -ggdb3 -O3 -DNDEBUG -isysroot /L
ibrary/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk -include /tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/cotire/et
-lib_CXX_prefix.hxx -std=gnu++17 -MD -MT CMakeFiles/et-lib.dir/src/base/SocketHandler.cpp.o -MF CMakeFiles/et-lib.dir/src/base/Soc
ketHandler.cpp.o.d -o CMakeFiles/et-lib.dir/src/base/SocketHandler.cpp.o -c /tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1
.8/src/base/SocketHandler.cpp
/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/src/terminal/TelemetryService.cpp:98:21: error: 'exists' is unavailable:
introduced in macOS 10.15
    if (filesystem::exists(telemetryConfigPath)) {
                    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:1617:39: note:
 'exists' has been explicitly marked unavailable here
inline _LIBCPP_INLINE_VISIBILITY bool exists(const path& __p) {
                                      ^
/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/src/terminal/TelemetryService.cpp:98:28: error: 'path' is unavailable: in
troduced in macOS 10.15
    if (filesystem::exists(telemetryConfigPath)) {
                           ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:773:3: note: '
path' has been explicitly marked unavailable here
  path(const _Source& __src, format = format::auto_format) {
  ^
/tmp/et-20210828-18195-1ecm1bw/EternalTerminal-et-v6.1.8/src/terminal/TelemetryService.cpp:98:28: error: '~path' is unavailable: i
ntroduced in macOS 10.15
    if (filesystem::exists(telemetryConfigPath)) {
                           ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:791:3: note: '
~path' has been explicitly marked unavailable here
  ~path() = default;

Thanks; I raised the issue so as to possibly highlight some problem with et, but TBH I'm out of my depth here and can't tell if this problem was caused by a missing tool or dependency on my part or a grub in the app, because of my lack of knowledge and skill. I did have Homebrew nagging me to update xcode tools and after some repetitive dl-ing from Apple Dev managed to make it happy. For the tyro tinkering around that I do it's not worthwhile installing Xcode as it's huge, should the lack of that be the problem. Thanks again.

@sqeeezy sqeeezy closed this as completed Aug 29, 2021
@ColCh
Copy link

ColCh commented Sep 9, 2021

Fro future lurkers :D

Indeed it can't be built on Mojave

It points on this line (and others)

https://github.com/MisterTea/EternalTerminal/blob/5b838440190b0e1a8d0333b4d940d156c0c0de03/src/terminal/TelemetryService.cpp#L94

as we can see, it was created at et-v6.1.0 tag, DIFF for it: MisterTea/EternalTerminal@et-v6.0.13...et-v6.1.0
Yup, here is PR that crated that file MisterTea/EternalTerminal#370

So, basically, latest et version supported in Mojave is v6.0.13

Install it by homebrew

~ $ brew tap-new tmp/et                                                                                                                                                   
~ $ brew tap mistertea/et                                                                                                                                                 
~ $ brew extract --version 6.0.13 mistertea/homebrew-et/et tmp/et
~ $ brew install et@6.0.13

(Based upon this answer on SO: https://stackoverflow.com/a/64125796/3278855)

Let me just copy messages from my terminal output (for fellow Googlers)

/tmp/et-20210909-24034-9ha876/EternalTerminal-et-v6.1.8/src/terminal/TelemetryService.cpp:98:21: error: 'exists' is unavailable: introduced in macOS 10.15
    if (filesystem::exists(telemetryConfigPath)) {
                    ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:1617:39: note: 'exists' has been explicitly marked unavailable here
inline _LIBCPP_INLINE_VISIBILITY bool exists(const path& __p) {
                                      ^
/tmp/et-20210909-24034-9ha876/EternalTerminal-et-v6.1.8/src/terminal/TelemetryService.cpp:98:28: error: 'path' is unavailable: introduced in macOS 10.15
    if (filesystem::exists(telemetryConfigPath)) {
                           ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:773:3: note: 'path' has been explicitly marked unavailable here
  path(const _Source& __src, format = format::auto_format) {
  ^
/tmp/et-20210909-24034-9ha876/EternalTerminal-et-v6.1.8/src/terminal/TelemetryService.cpp:98:28: error: '~path' is unavailable: introduced in macOS 10.15
    if (filesystem::exists(telemetryConfigPath)) {
                           ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:791:3: note: '~path' has been explicitly marked unavailable here
  ~path() = default;
  ^
/tmp/et-20210909-24034-9ha876/EternalTerminal-et-v6.1.8/src/terminal/TelemetryService.cpp:114:19: error: 'create_directories' is unavailable: introduced in macOS 10.15
      filesystem::create_directories(sago::getConfigHome() + "/et");
                  ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:1548:39: note: 'create_directories' has been explicitly marked unavailable here
inline _LIBCPP_INLINE_VISIBILITY bool create_directories(const path& __p) {
                                      ^
/tmp/et-20210909-24034-9ha876/EternalTerminal-et-v6.1.8/src/terminal/TelemetryService.cpp:114:38: error: 'path' is unavailable: introduced in macOS 10.15
      filesystem::create_directories(sago::getConfigHome() + "/et");
                                     ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:769:3: note: 'path' has been explicitly marked unavailable here
  path(string_type&& __s, format = format::auto_format) noexcept
  ^
/tmp/et-20210909-24034-9ha876/EternalTerminal-et-v6.1.8/src/terminal/TelemetryService.cpp:114:38: error: '~path' is unavailable: introduced in macOS 10.15
      filesystem::create_directories(sago::getConfigHome() + "/et");
                                     ^
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/filesystem:791:3: note: '~path' has been explicitly marked unavailable here
  ~path() = default;
  ^


6 errors generated.
make[2]: *** [CMakeFiles/TerminalCommon.dir/src/terminal/TelemetryService.cpp.o] Error 1
make[1]: *** [CMakeFiles/TerminalCommon.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....



[ 54%] Linking CXX static library libet-lib.a
/usr/local/Cellar/cmake/3.21.2/bin/cmake -P CMakeFiles/et-lib.dir/cmake_clean_target.cmake
/usr/local/Cellar/cmake/3.21.2/bin/cmake -E cmake_link_script CMakeFiles/et-lib.dir/link.txt --verbose=1
/usr/bin/ar qc libet-lib.a CMakeFiles/et-lib.dir/external_imported/easyloggingpp/src/easylogging++.cc.o CMakeFiles/et-lib.dir/external_imported/PlatformFolders/sago/platform_folders.cpp.o CMakeFiles/et-lib.dir/src/base/BackedReader.cpp.o CMakeFiles/et-lib.dir/src/base/BackedWriter.cpp.o CMakeFiles/et-lib.dir/src/base/ClientConnection.cpp.o CMakeFiles/et-lib.dir/src/base/Connection.cpp.o CMakeFiles/et-lib.dir/src/base/CryptoHandler.cpp.o CMakeFiles/et-lib.dir/src/base/ServerClientConnection.cpp.o CMakeFiles/et-lib.dir/src/base/ServerConnection.cpp.o CMakeFiles/et-lib.dir/src/base/SocketHandler.cpp.o CMakeFiles/et-lib.dir/src/base/PipeSocketHandler.cpp.o CMakeFiles/et-lib.dir/src/base/TcpSocketHandler.cpp.o CMakeFiles/et-lib.dir/src/base/UnixSocketHandler.cpp.o CMakeFiles/et-lib.dir/src/base/LogHandler.cpp.o CMakeFiles/et-lib.dir/src/base/DaemonCreator.cpp.o CMakeFiles/et-lib.dir/src/base/RawSocketUtils.cpp.o CMakeFiles/et-lib.dir/src/base/SubprocessToString.cpp.o CMakeFiles/et-lib.dir/ET.pb.cc.o
/usr/bin/ranlib libet-lib.a
[ 54%] Built target et-lib
make: *** [all] Error 2

@dgentry
Copy link

dgentry commented Sep 10, 2021

Thank you for that update! I'm not sure I would have closed this until it actually builds on Mojave, but the workaround build instructions are good enough for me.

I think the PR that introduced this line is actually MisterTea/EternalTerminal#395, but version 6.0.13 is still the last version that will build on Mojave. It looks like this incompatibility came with the introduction of Telemetry.

If I get motivated, I'll see if I can conditionalize the code so it uses an alternative to filesystem::exists() (Boost has had s::f::exists() for a long time) on Mojave, or maybe just don't build Telemetry. I think the check for exists() is either superfluous or a race or both, because the code goes on to check (by opening) if the config file is complete and readable, and reports errors if it's not. Checking for an error after opening is better because it doesn't have the race where the file can disappear after the exists() check.

@MisterTea MisterTea reopened this Sep 11, 2021
@MisterTea
Copy link
Owner

Hey all, just arriving at this thread now.

Telemetry has been extremely useful in helping me fix bugs, especially ones that occur very rarely.

With that said, I don't want telemetry to be a reason why people can't use ET.

If anyone submits a PR with a cmake flag to disable telemetry with compile definitions, I'll approve it and it will go out with the next release.

@MisterTea
Copy link
Owner

Also reverting to 6.0.13 isn't a good workaround as it misses many important bug fixes (that we found because of the telemetry 😅)

@dgentry
Copy link

dgentry commented Sep 11, 2021 via email

@MisterTea
Copy link
Owner

@dgentry can you verify that this works? I don't have any machines running mojave: MisterTea/EternalTerminal#459

@MisterTea
Copy link
Owner

Fixed by MisterTea/EternalTerminal#459

@ColCh
Copy link

ColCh commented Sep 11, 2021

Wow guys that was fast! Thank you all a lot!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MisterTea @ColCh @dgentry @sqeeezy