Merge pull request #22 from jwilsson/iife-arrow-functions

Fix false positive for arrow function IIFEs
MitMaro · Aug 15, 2016 · a72d2b4 · a72d2b4
2 parents a7dc674 + b9a3cf4
commit a72d2b4
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/lib/rules/strict-newline.js b/lib/rules/strict-newline.js
@@ -25,7 +25,8 @@ module.exports = function (context) {
 			if (node.body.length === 1
 				&& node.body[0].type === 'ExpressionStatement'
 				&& node.body[0].expression.type === 'CallExpression'
-				&& node.body[0].expression.callee.type === 'FunctionExpression'
+				&& (node.body[0].expression.callee.type === 'FunctionExpression'
+				|| node.body[0].expression.callee.type === 'ArrowFunctionExpression')
 				&& node.body[0].expression.callee.body.type === 'BlockStatement'
 			) {
 				bodyToCheck = node.body[0].expression.callee.body.body;

diff --git a/test/lib/rules/strict-newline.js b/test/lib/rules/strict-newline.js
@@ -3,7 +3,9 @@
 var rule = require('../../../lib/rules/strict-newline');
 var RuleTester = require('eslint').RuleTester;
 
-var parserOptions = {};
+var parserOptions = {
+	ecmaVersion: 6
+};
 
 var ruleTester = new RuleTester();
 ruleTester.run('strict-newline', rule, {
@@ -69,6 +71,15 @@ ruleTester.run('strict-newline', rule, {
 				'var a;})()'
 			].join('\n'),
 			parserOptions: parserOptions
+		},
+		{
+			code: [
+				'(()=>{',
+				'"use strict"',
+				'',
+				'var a;})()'
+			].join('\n'),
+			parserOptions: parserOptions
 		}
 	],
 
@@ -131,6 +142,24 @@ ruleTester.run('strict-newline', rule, {
 			].join('\n'),
 			parserOptions: parserOptions,
 			errors: [{message: 'Expected newline after \'use strict\''}]
+		},
+		{
+			code: [
+				'(()=>{',
+				'"use strict"',
+				'var a;})();'
+			].join('\n'),
+			parserOptions: parserOptions,
+			errors: [{message: 'Expected newline after \'use strict\''}]
+		},
+		{
+			code: [
+				'(()=>{',
+				'"use strict";var a;',
+				'})();'
+			].join('\n'),
+			parserOptions: parserOptions,
+			errors: [{message: 'Expected newline after \'use strict\''}]
 		}
 	]
 });