History fix when when file is empty. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2021 22:55
The history file, located in `~/.mitype_history.csv` must contain csv data holding all user typing history. If this file is empty, without csv header, a `StopIteration` is raised, crashing `mitype`. This commit fix this exception and print a string, showing no records found. This fixes bug Mithil467#108
The `show_history` method aim to print history logs of the users. It has a single `number_record` parameter used to select the number of record to print. The major part of this function is used to extract the log data from the `.mitype_history.csv` csv file. The other part is used to print this extract. This commit separate this two features in order to clean the code and ease testing.
rpesche
force-pushed
the
history_file_fix
branch
from
db0e1f9
to
8005a85
Compare
|
Thanks @rpesche for the issue! |
Mithil467
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix #108
I also add some test using
pytest.In order to more easily test
show_historyI made a little refactoring, spliting it into two methodshow_historyandget_history_record.I know the contributing guide say we must make single bug per PR, but I'm used to work in TDD, and there is no tests in mitype.