Merge pull request #1753 from StephanHoyer/master

Fix rendering `0` as only child without attrs - fixes #1752
MithrilJS · Mar 28, 2017 · 000eec9 · 000eec9
2 parents e88bddb + 7960781
commit 000eec9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/render/hyperscript.js b/render/hyperscript.js
@@ -73,7 +73,7 @@ function hyperscript(selector) {
 		var cached = selectorCache[selector] || compileSelector(selector)
 	}
 
-	if (!attrs) {
+	if (attrs == null) {
 		attrs = {}
 	} else if (typeof attrs !== "object" || attrs.tag != null || Array.isArray(attrs)) {
 		attrs = {}

diff --git a/render/tests/test-hyperscript.js b/render/tests/test-hyperscript.js
@@ -273,6 +273,11 @@ o.spec("hyperscript", function() {
 			o(vnode.children[0]).equals(null)
 			o(vnode.children[1]).equals(undefined)
 		})
+		o("handles falsy number single child without attrs", function() {
+			var vnode = m("div", 0)
+
+			o(vnode.text).equals(0)
+		})
 	})
 	o.spec("permutations", function() {
 		o("handles null attr and children", function() {