Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp fix for #1831 #1893

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Temp fix for #1831 #1893

merged 1 commit into from
Jul 11, 2017

Conversation

pygy
Copy link
Member

@pygy pygy commented Jul 11, 2017

I'd rather not remove the stream/stream.js IIFE for a patch release... @spacejack is this ok for you (for now)?

@pygy pygy merged commit c7d33c7 into MithrilJS:next Jul 11, 2017
@pygy
Copy link
Member Author

pygy commented Jul 11, 2017

Merging for now. There's a larger discussion to be had about file layout (right now package.json:main points to the bundle, meaning that if someone imports the bundle somewhere and only specific modules elsewhere they will end up with different files and functions. This may be relevant for isomorphism considerations (two vnode factories)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant