Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show previous versions #2353

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

mike-ward
Copy link
Contributor

@mike-ward mike-ward commented Dec 30, 2018

Description

  • Add Dropdown that shows links to archived versions of the documentation.
  • Modify generate.js to checkout /archive from `gh-pages', read folder for previous version names and then reset and delete.
  • Add rimraf as dev dependency to delete checked-out archive folder.
  • Change layout.html to provide replace target for generated <select> tag.

Motivation and Context

#2334

How Has This Been Tested?

Presented working mock-up on Gitter chat for approval.
Ran locally after running gendocs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

@dead-claudia
Copy link
Member

@tivac I requested a review from you because you're most familiar with how Travis is set up. This was based on my guidance, and I'm just looking for a sanity check here in case I screwed up on my end.

@StephanHoyer
Copy link
Member

@mike-ward I just rebased this PR to current next branch. Maybe you can give it a review?

Copy link
Member

@StephanHoyer StephanHoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just rebased against next. Had to rework some stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed/Declined
Development

Successfully merging this pull request may close these issues.

3 participants