Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[m.request] work around a bundler bug, fix #2647 #2655

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Conversation

pygy
Copy link
Member

@pygy pygy commented Jan 16, 2021

The bundler mangles identifier-like strings within RegExps, this works around the problem by not using such RegExps.

Description

Motivation and Context

#2647

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/changelog.md

@StephanHoyer StephanHoyer merged commit 6aeb038 into next Jan 25, 2022
@StephanHoyer StephanHoyer deleted the fix-2647 branch January 25, 2022 20:44
@JAForbes JAForbes mentioned this pull request Apr 28, 2022
@orbitbot orbitbot added the patch label May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants