Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in stream() docs #2825

Merged
merged 3 commits into from
Mar 12, 2023
Merged

Fix typos in stream() docs #2825

merged 3 commits into from
Mar 12, 2023

Conversation

mtsknn
Copy link
Contributor

@mtsknn mtsknn commented Mar 10, 2023

Description

Noticed these typos while reading through the page.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/changelog.md

dead-claudia
dead-claudia requested changes Mar 11, 2023
View reviewed changes
Copy link
Member

@dead-claudia dead-claudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was about to just accept, but since we're here, I decided to tack on a couple other changes if you'd like to merge them in.

docs/stream.md Outdated Show resolved Hide resolved
docs/stream.md Outdated Show resolved Hide resolved
mtsknn and others added 2 commits March 11, 2023 08:51
@mtsknn @dead-claudia
Remove word
18015ec 
Co-authored-by: Claudia Meadows <contact@claudiameadows.dev>
@mtsknn @dead-claudia
Remove comma
92d39c4 
Co-authored-by: Claudia Meadows <contact@claudiameadows.dev>
@mtsknn mtsknn requested review from dead-claudia and removed request for StephanHoyer March 11, 2023 06:52
@dead-claudia dead-claudia merged commit ad9aa97 into MithrilJS:next Mar 12, 2023
@JAForbes JAForbes mentioned this pull request Mar 12, 2023
Open
@mtsknn mtsknn deleted the patch-1 branch March 12, 2023 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-claudia dead-claudia dead-claudia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtsknn @dead-claudia