Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repository slug lowercase #70

Merged
merged 4 commits into from
Dec 5, 2018
Merged

Repository slug lowercase #70

merged 4 commits into from
Dec 5, 2018

Conversation

anh-duc-le
Copy link

Added ToLowerInvariant() to the repo slug in the POST Repository method. This will prevent the API error below.

{     
    "type": "error",    
    "error": {    
    "message": "Invalid slug. Slugs must be lowercase, alphanumerical, and may also contain underscores, dashes, or dots."
    }
}

Anh-Duc Le added 3 commits April 25, 2018 14:39
Added README.md and comments for the following:
7f87869 
In order to run the ConsoleTests you'll first need the following:

* You need at least 5 changesets in your repository.
* You need at least 5 issues in your repository.
* You need at least 1 SSH Key on your user
repo slug to ToLowerInvariant, uppercase characters will cause issues…
c6b0222 
… in the API.
removed wrong files
580e73e
@anh-duc-le anh-duc-le mentioned this pull request Apr 26, 2018
Closed
mnivet
mnivet reviewed Nov 29, 2018
View reviewed changes
.gitignore
!packages/repositories.config
/.vs/SharpBucket/v15/Server/sqlite3
Copy link
Collaborator

@mnivet mnivet Nov 29, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be just /.vs/

Suggested change
/.vs/SharpBucket/v15/Server/sqlite3
/.vs/

@mnivet mnivet self-assigned this Dec 3, 2018
@mnivet mnivet merged commit e5cbc70 into MitjaBezensek:master Dec 5, 2018
This was referenced Dec 18, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnivet mnivet mnivet approved these changes

Assignees

@mnivet mnivet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anh-duc-le @mnivet