feat: add ability to disable admin password #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump, would love to see this feature land. |
|
Hey, I was working on another PR yesterday. I hope i get it managed this weekend :) |
Signed-off-by: Christian Erhardt <christian.erhardt@mojo2k.de>
|
A little later than expected, but your change LGTM. I only updated the readme file. Will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds option
admin.enabled(default true) which if set to false disables admin password.Closes: #251
Follows similar approach to taken by PR #261 but does not create secret if admin password is disabled.
From my understanding suggestion made on PR #261 will not work as there is no way to distinguish value not set and value set to empty string in golang/helm templates. Hence why additional
admin.enabledordisablePasswordfield is required.