Add sitemap webpack plugin #907
Conversation
|
|
||
| The ``phenomicLoader`` allows you to generate sitemap very easily. | ||
|
|
||
| The phenomic-theme-base already handles a default RSS sitemap that will grab all your urls |
There was a problem hiding this comment.
According to sitemap's README, it generates a XML sitemap, not a RSS one.
There was a problem hiding this comment.
of course, my bad
cedricdelpoux
force-pushed
the
sitemap-webpack-plugin
branch
2 times, most recently
from
1cd51ba
to
8c17437
Compare
| @@ -125,6 +125,7 @@ | |||
| "react-router": "^2.3.0", | |||
| "react-test-renderer": "^15.3.2", | |||
| "redux": "^3.0.0", | |||
| "sitemap": "~1.8.2", | |||
There was a problem hiding this comment.
Can you use ^ instead of ~ like other package?
Also can you use yarn so the lock file is updated?
There was a problem hiding this comment.
Done. But the yarn.lock is not under version. So what is the point to run it locally ?
There was a problem hiding this comment.
Yeah you are right, I removed it :D but will add it back.
cedricdelpoux
force-pushed
the
sitemap-webpack-plugin
branch
2 times, most recently
from
3026f48
to
8f3d904
Compare
|
anything I can do to move on ? |
| @@ -125,6 +125,7 @@ | |||
| "react-router": "^2.3.0", | |||
| "react-test-renderer": "^15.3.2", | |||
| "redux": "^3.0.0", | |||
| "sitemap": "^1.8.2", | |||
There was a problem hiding this comment.
Done. Sitemap is generated during build so I believed package used for this were in dev deps. But I saw the rss dep was in deps too
cedricdelpoux
force-pushed
the
sitemap-webpack-plugin
branch
from
8f3d904
to
e54c475
Compare
| @@ -0,0 +1,51 @@ | |||
| --- | |||
| title: How to use generate sitemap in Phenomic | |||
There was a problem hiding this comment.
How to generate a sitemap with Phenomic?
| title: How to use generate sitemap in Phenomic | ||
| --- | ||
|
|
||
| The ``phenomicLoader`` allows you to generate sitemap very easily. |
There was a problem hiding this comment.
Phenomic allows you to generate a sitemap very easily if you use the phenomicLoader.
|
|
||
| The ``phenomicLoader`` allows you to generate sitemap very easily. | ||
|
|
||
| The phenomic-theme-base already handles a default XML sitemap that will grab all your urls |
There was a problem hiding this comment.
add a . at the end of the line please.
cedricdelpoux
force-pushed
the
sitemap-webpack-plugin
branch
from
e54c475
to
addecbb
Compare
|
Thank you for your feedback. I corrected last typos |
fix #621