Skip to content

Commit

Permalink
Fix Edge form support (#178)
Browse files Browse the repository at this point in the history
* Fix looping through form elements in Edge

* Update lockfile
  • Loading branch information
robinnorth authored and BehindTheMath committed Oct 10, 2018
1 parent 6b648a7 commit 52fb3bf
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 11 deletions.
17 changes: 7 additions & 10 deletions lib/proto/attach-form.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,10 @@ var formAction = function(el, event) {

function parseFormElements(el) {
var requestParams = []
var formElements = el.elements

for (var elementKey in el.elements) {
if (Number.isNaN(Number(elementKey))) {
continue;
}

var element = el.elements[elementKey]
for (var i = 0; i < formElements.length; i++) {
var element = formElements[i]
var tagName = element.tagName.toLowerCase()
// jscs:disable disallowImplicitTypeConversion
if (!!element.name && element.attributes !== undefined && tagName !== "button") {
Expand All @@ -65,8 +62,8 @@ function parseFormElements(el) {
if (tagName === "select") {
var opt

for (var i = 0; i < element.options.length; i++) {
opt = element.options[i]
for (var j = 0; j < element.options.length; j++) {
opt = element.options[j]
if (opt.selected && !opt.disabled) {
values.push(opt.hasAttribute("value") ? opt.value : opt.text)
}
Expand All @@ -76,10 +73,10 @@ function parseFormElements(el) {
values.push(element.value)
}

for (var j = 0; j < values.length; j++) {
for (var k = 0; k < values.length; k++) {
requestParams.push({
name: encodeURIComponent(element.name),
value: encodeURIComponent(values[j])
value: encodeURIComponent(values[k])
})
}
}
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 52fb3bf

Please sign in to comment.