Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #1166 from Kaiepi/ipv6-unsupported" #1207

Merged
merged 2 commits into from Oct 26, 2019

Conversation

Kaiepi
Copy link
Contributor

@Kaiepi Kaiepi commented Oct 24, 2019

While only the change to make all addresses get used when connecting or
binding sockets needs to be reverted from this, not every commit had
only one change included with it, making it impossible to tell if it had
truly been reverted or not. They will be remade later.

This reverts commit 39f5774, reversing
changes made to 01f85c8.

While only the change to make all addresses get used when connecting or
binding sockets needs to be reverted from this, not every commit had
only one change included with it, making it impossible to tell if it had
truly been reverted or not. They will be remade later.

This reverts commit 39f5774, reversing
changes made to 01f85c8.
@AlexDaniel
Copy link
Contributor

AlexDaniel commented Oct 25, 2019

Currently it doesn't pass CI tests.

src\io\asyncsocketudp.c(557) : error C2039: 'async_task' : is not a member of 'SocketSetupInfo'
src\io\asyncsocketudp.c(487) : see declaration of 'SocketSetupInfo'

The changes to how async UDP sockets no longer exist, so this isn't
necessary to do until they're added back.

This reverts commit db9b770.
@Kaiepi
Copy link
Contributor Author

Kaiepi commented Oct 25, 2019

This now passes make spectest.

@AlexDaniel
Copy link
Contributor

Should be good now, I think!

Thanks!

@AlexDaniel AlexDaniel merged commit 769faa1 into MoarVM:master Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants