Some staticframe fixups #1301
Merged
Some staticframe fixups #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied frames aren't usually run, but the lexical_names_list should be copied for correctness sake.
"lexical_names and lexical_names_list are [...] always created at the same time, and we can't have duplicate lexical names, and so HASH_CNT() on lexical_names should always be the same as num_lexicals, and would be cheaper written as that." - nwc10, https://colabti.org/irclogger/irclogger_log/moarvm?date=2020-06-01#l20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NQP builds ok and passes
make m-testand Rakudo builds ok and passesmake m-test m-spectest.