-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coerce s n #588
Coerce s n #588
Conversation
It's still missing support for radixes other then decimal. The coerce_s_n behavior now shouldn't be OS dependent.
src/strings/parse_num.h
Outdated
@@ -0,0 +1 @@ | |||
MVMnum64 MVM_coerce_s_n_new(MVMThreadContext *tc, MVMString *s); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MVM_coerce_s_n
me thinks?
Fixed.
…On 30 April 2017 at 16:35, Jimmy Zhuo ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/strings/parse_num.h
<#588 (comment)>:
> @@ -0,0 +1 @@
+MVMnum64 MVM_coerce_s_n_new(MVMThreadContext *tc, MVMString *s);
MVM_coerce_s_n me thinks?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#588 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGXpiG8N5n9PairfjaAZRThjVaFl0NEks5r1Jw-gaJpZM4NMkN8>
.
|
NQP tests where doing some incorrect conversions that where uncovered by this PR. |
Finally got around to reviewing this (sorry it took a while), and it looks good overall to me. Release is very soon, so suggest merging this just after that. |
Make coercing a str to a num behave more like the .Num method.
Make it no longer os dependent.