Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coerce s n #588

Merged
merged 8 commits into from
May 20, 2017
Merged

Coerce s n #588

merged 8 commits into from
May 20, 2017

Conversation

pmurias
Copy link
Contributor

@pmurias pmurias commented Apr 30, 2017

Make coercing a str to a num behave more like the .Num method.
Make it no longer os dependent.

@@ -0,0 +1 @@
MVMnum64 MVM_coerce_s_n_new(MVMThreadContext *tc, MVMString *s);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MVM_coerce_s_n me thinks?

@pmurias
Copy link
Contributor Author

pmurias commented Apr 30, 2017 via email

@pmurias
Copy link
Contributor Author

pmurias commented May 1, 2017

NQP tests where doing some incorrect conversions that where uncovered by this PR.
I fixed those tests.

@jnthn
Copy link
Member

jnthn commented May 19, 2017

Finally got around to reviewing this (sorry it took a while), and it looks good overall to me. Release is very soon, so suggest merging this just after that.

@zhuomingliang zhuomingliang merged commit 37460c7 into MoarVM:master May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants