Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the semi-colon from insecure Random Regex #1611

Merged
merged 1 commit into from Dec 3, 2020

Conversation

diazjf
Copy link
Contributor

@diazjf diazjf commented Dec 3, 2020

Describe the Pull Request

Removes the semi-colon from the insecure random regex rule. In Kotlin the semi-colon is not required, and we want to
catch this vulnerability in applications built with Kotlin. https://kotlinlang.org/docs/reference/packages.html#imports

Checklist for PR

  • Run MobSF unit tests and lint tox -e lint,test.
  • Tested Working on Linux, Mac, Windows, and Docker
  • Make sure build is passing on your PR. Build Status

Additional Comments (if any)

There should be an issue with past compatibility, and should still apply to java code.

Removes the semi-colon from the insecure  random regex rule. In Kotlin the semi-colon is not required, and we want to
catch this vulnerability in applications built with Kotlin. https://kotlinlang.org/docs/reference/packages.html#imports
@ajinabraham ajinabraham merged commit eef603b into MobSF:master Dec 3, 2020
@ajinabraham
Copy link
Member

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants