-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of button and rotaryencoder libs #2
Comments
As far as I know how to issue pull requests I will try to make my first one ;) |
@elral the easiest way is if you are in VSCode to use the GitHub Pull Requests and Issues extension.
|
@danecreekphotography, thanks a lot for your hints. Took some time to understand, and in the end I had to do step 4 on the github page. Didn't find what you explained. |
I "found" that the original library (in platformio.ini "mathertel/RotaryEncoder @ ^1.5.2") got recently some updates. The button and TicksPerSecond lib is not used anymore. Acceleration can now be done via "::getMillisBetweenRotations()". There are some more little changes in MFEncoder.cpp required (which I prepared already). RAM usage is reduced by ~300Bytes!? BUT encoders with 4 Steps per cycle are NOT supported anymore. Are there at all these rotary encoder (for inputs, not for detecting shaft rotating w/o detents) existing? For me I never had them and never saw them, only 1 and 1 detents per cycle. Does this somebody know? |
@elral Just to reduce the amount of churn happening in the firmware in a single release (and there's a lot of combined changes for this PlatformIO move), my suggestion is to stick with what you already did that's based on the current version of the library that's well understood for MobiFlight usage. |
From the MobiFlight issue elral has good changes to include:
The text was updated successfully, but these errors were encountered: