Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription APIs mix NSObjectProtocol and NSObject #682

Closed
guillerodriguez opened this issue Aug 25, 2022 · 4 comments
Closed

Subscription APIs mix NSObjectProtocol and NSObject #682

guillerodriguez opened this issue Aug 25, 2022 · 4 comments

Comments

@guillerodriguez
Copy link

Some subscription APIs return a NSObjectProtocol (e.g. UIWindow.observeKeyboardWillShown), however NSNotificationCenter.removeObserver expects a NSObject.

Looks like subscription APIs were switched from NSObject to NSObjectProtocol in this commit. This was later reverted (see commit). However apparently not all cases were reverted.

This affects robovm-2.3.16 upwards and is also present in current master.
@dkimitsa
Copy link
Contributor

@guillerodriguez please check the PR #683
thx

@guillerodriguez
Copy link
Author

@dkimitsa LGTM, will test once this lands in a snapshot.

@dkimitsa
Copy link
Contributor

@guillerodriguez its part of 2.3.19 release

@guillerodriguez
Copy link
Author

Thank you!

@Tom-Ski Tom-Ski closed this as completed Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@guillerodriguez @Tom-Ski @dkimitsa