* desugar: added compiler plugin that extends ByteBuffer with Java9 API #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Overview
Java9 adds overridden methods with covariant return types in ByteBuffer:
- flip
- clear
- mark
- reset
- rewind
- position
- limit
It becomes problem when using external dependency that was compiled as `-release 9` and caused exceptions:
> java.lang.NoSuchMethodError: java.nio.ByteBuffer.limit(I)Ljava/nio/ByteBuffer
The only options is to re-compile the dependency. But it is not always possible.
## Discussion
This might be achieved by just adapting runtime classes but having it as Plugin allows to enable or disable the behaviour.
## Other changes
Desugar plugins were extended with option to disable using plugin arguments:
```
<pluginArguments>
<argument>desugar:enableJdk9ByteBufferApi=false</argument>
<argument>desugar:enableJava9StringConcat=false</argument>
</pluginArguments>
```
# Conflicts: # compiler/compiler/src/main/java/org/robovm/compiler/config/Config.java
… new methods were added. Otherwise it will produce NPE while trying to pick entries for these new added methods
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Java9 adds overridden methods with covariant return types in ByteBuffer:
It becomes problem when using external dependency that was compiled as
-release 9and caused exceptions:Discussion
This might be achieved by just adapting runtime classes but having it as Plugin allows to enable or disable the behaviour.
Other changes
Desugar plugins were extended with option to disable using plugin arguments: