Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobiflight Modules settings Cancel button cannot be cancelled #408

Closed
JaimeLeon2 opened this issue Jul 14, 2021 · 1 comment
Closed

Mobiflight Modules settings Cancel button cannot be cancelled #408

JaimeLeon2 opened this issue Jul 14, 2021 · 1 comment
Labels
bug Something isn't working in a officially released version UI
Milestone

Comments

@JaimeLeon2
Copy link

JaimeLeon2 commented Jul 14, 2021

Describe the bug
In Mobiflight Modules settings, pressing Cancel gives a warning that there are unsaved changes. However, pressing Cancel in this dialog does not go back to previous window to give the user a chance to save. Both buttons: OK and Cancel take you back to the Main Window. Any changes are then lost.

Steps To Reproduce

  1. Enter Settings > Mobiflight Modules
  2. Select a module and create a new device
  3. Press Cancel instead of OK
  4. MF gives you a warning that there are unsaved changes
  5. Press Cancel

image

Expected behavior
Pressing Cancel should take you back to the Mobiflight Modules window, so the user can save. Only pressing OK should exit to the Main Window.

Actual behavior
Pressing any of the buttons: OK or Cancel takes you to the MF Main Window and all changes are lost.

Details

  • MobiFlight Version: 8.2.0.3 beta
  • FlightSim: not relevant
  • AddOn: not relevant

Additional context
There is no point in warning the user that there are unsaved changes, if he cannot go back to save.
You might also want to correct the mispelled word "loose" in this dialog to "lose".

@MobiFlight-Admin MobiFlight-Admin added this to Ready For Departure in MobiFlight 9.2 Jul 14, 2021
@MobiFlight-Admin MobiFlight-Admin moved this from Ready For Departure to Cruise Flight in MobiFlight 9.2 Jul 14, 2021
@MobiFlight-Admin
Copy link
Collaborator

This is fixed. I had to set the dialogResult for the Settings Dialog explicitly to
DialogResult = DialogResult.None

@MobiFlight-Admin MobiFlight-Admin moved this from Cruise Flight to Beta Arrival in MobiFlight 9.2 Jul 14, 2021
@MobiFlight-Admin MobiFlight-Admin added this to the 8.2.0.4 milestone Jul 14, 2021
@MobiFlight-Admin MobiFlight-Admin added bug Something isn't working in a officially released version UI labels Jul 22, 2021
@MobiFlight-Admin MobiFlight-Admin moved this from Beta Arrival to Release Approach in MobiFlight 9.2 Jul 25, 2021
@MobiFlight-Admin MobiFlight-Admin moved this from Release Approach to Beta Arrival in MobiFlight 9.2 Aug 6, 2021
@MobiFlight-Admin MobiFlight-Admin moved this from Beta Arrival to Touch Down in MobiFlight 9.2 Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in a officially released version UI
Projects
No open projects
MobiFlight 9.2
Touch Down
Development

No branches or pull requests

2 participants