Add rootOutput option, to store the HTML report into the given path #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 4, 2020 12:52
# Conflicts: # Sources/XCLogParser/commands/ActionOptions.swift # Sources/XCLogParserApp/commands/ParseCommand.swift
ecamacho
reviewed
Sep 4, 2020
| var path = "build/xclogparser/reports" | ||
| if let rootOutput = rootOutput { |
There was a problem hiding this comment.
I think rootOutput should have precedence over output. Currently, if you specify both the tool will use output. Can you change that? And put a comment in the doc that if specified, root will be used over output?
added 2 commits
September 4, 2020 17:12
ecamacho
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does?
Adds a new option to store HTML report into the given path.
Why?
There is no way to store an HTML report in a custom folder by the user.
#98
@ecamacho