Add IDEActivityLogActionMessage support #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mollyIV Sorry for the delay! Do you mind fixing the DCO check and possibly add a few tests? There's a test class for this specific logic which we can use. |
Signed-off-by: Daniel Jankowski <daniell.jankowskii@gmail.com>
mollyIV
force-pushed
the
add-IDEActivityLogActionMessage-support
branch
from
b349363
to
415c58c
Compare
Signed-off-by: Daniel Jankowski <daniell.jankowskii@gmail.com>
mollyIV
requested review from
polac24,
ecamacho,
aleksandergrzyb and
CognitiveDisson
as code owners
|
Hey @BalestraPatrick 👋 No worries 😊 I fixed DCO check and added a unit test. Thanks for pointing to a test class. Let me know if there's anything else I can do, thanks! |
|
Looks good to me! One minor linter failure which you can disable with |
Signed-off-by: Daniel Jankowski <daniell.jankowskii@gmail.com>
BalestraPatrick
approved these changes
Nov 13, 2023
BalestraPatrick
merged commit 0615500
into
MobileNativeFoundation:master
4 checks passed
|
Thanks for pushing this through! Is there a plan to get this into a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #187.
Add IDEActivityLogActionMessage support.