Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 11.5 support #447

Merged
merged 1 commit into from
Jun 7, 2020
Merged

Xcode 11.5 support #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/PR.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ jobs:
steps:
# actions/checkout@v2 but we use the SHA1 because tags can be re-written in git
- uses: actions/checkout@722adc63f1aa60a57ec37892e133b1d319cae598
- name: Select Xcode 11.4
run: sudo xcode-select -s /Applications/Xcode_11.4.app
- name: Select Xcode 11.5
run: sudo xcode-select -s /Applications/Xcode_11.5.app
- name: Run Bluepill tests
run: ./scripts/bluepill.sh instance_tests

Expand All @@ -22,8 +22,8 @@ jobs:
steps:
# actions/checkout@v2 but we use the SHA1 because tags can be re-written in git
- uses: actions/checkout@722adc63f1aa60a57ec37892e133b1d319cae598
- name: Select Xcode 11.4
run: sudo xcode-select -s /Applications/Xcode_11.4.app
- name: Select Xcode 11.5
run: sudo xcode-select -s /Applications/Xcode_11.5.app
- name: Run BP tests
run: ./scripts/bluepill.sh runner_tests
- name: Build and Package
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ jobs:
steps:
# actions/checkout@v2 but we use the sha because tags can be rewritten in git
- uses: actions/checkout@722adc63f1aa60a57ec37892e133b1d319cae598
- name: Select Xcode 11.4
run: sudo xcode-select -s /Applications/Xcode_11.4.app
- name: Select Xcode 11.5
run: sudo xcode-select -s /Applications/Xcode_11.5.app
- name: Run Bluepill tests
run: ./scripts/bluepill.sh instance_tests

Expand All @@ -27,8 +27,8 @@ jobs:
steps:
# actions/checkout@v2 but we use the sha because tags can be rewritten in git
- uses: actions/checkout@722adc63f1aa60a57ec37892e133b1d319cae598
- name: Select Xcode 11.4
run: sudo xcode-select -s /Applications/Xcode_11.4.app
- name: Select Xcode 11.5
run: sudo xcode-select -s /Applications/Xcode_11.5.app
- name: Run BP tests
run: ./scripts/bluepill.sh runner_tests
- name: Build and Package
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
steps:
# actions/checkout@v2 but we use the sha because tags can be rewritten in git
- uses: actions/checkout@722adc63f1aa60a57ec37892e133b1d319cae598
- name: Select Xcode 11.4
run: sudo xcode-select -s /Applications/Xcode_11.4.app
- name: Select Xcode 11.5
run: sudo xcode-select -s /Applications/Xcode_11.5.app
- name: Run Bluepill tests
run: ./scripts/bluepill.sh instance_tests

Expand All @@ -28,8 +28,8 @@ jobs:
- name: Report event trigger data
run: |
echo "Event ${{ github.event_name }}, ref: ${{ github.ref }}"
- name: Select Xcode 11.4
run: sudo xcode-select -s /Applications/Xcode_11.4.app
- name: Select Xcode 11.5
run: sudo xcode-select -s /Applications/Xcode_11.5.app
- name: Run Bluepill tests
run: ./scripts/bluepill.sh runner_tests
- name: Build Bluepill
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ Here is a list of Bluepill exit codes. If a Bluepill execution has multiple exit

## Requirements

Bluepill officially supports **Xcode 11.4**. If you're looking for old Xcode support, please check out the below branches:
Bluepill officially supports **Xcode 11.5**. If you're looking for old Xcode support, please checkout the following branches:

* [Xcode-8](https://github.com/linkedin/bluepill/tree/xcode8)
* [Xcode-9.0](https://github.com/linkedin/bluepill/tree/xcode-9.0)
Expand All @@ -134,6 +134,7 @@ Bluepill officially supports **Xcode 11.4**. If you're looking for old Xcode sup
* [Xcode-11.1](https://github.com/linkedin/bluepill/tree/xcode-11.1)
* [Xcode-11.2](https://github.com/linkedin/bluepill/tree/xcode-11.2)
* [Xcode-11.3](https://github.com/linkedin/bluepill/tree/xcode-11.3)
* [Xcode-11.4](https://github.com/linkedin/bluepill/tree/xcode-11.4)

If you're looking for newer Xcode version support, try using Bluepill with `unsafe-skip-xcode-version-check` flag but make sure your app is tested with it and the underlying risks are understand.

Expand Down
6 changes: 3 additions & 3 deletions bp/src/BPConstants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
#import <Foundation/Foundation.h>

#pragma mark - Version Constants
#define BP_DEFAULT_XCODE_VERSION "11.4"
#define BP_DEFAULT_RUNTIME "iOS 13.4"
#define BP_DEFAULT_BASE_SDK "13.4"
#define BP_DEFAULT_XCODE_VERSION "11.5"
#define BP_DEFAULT_RUNTIME "iOS 13.5"
#define BP_DEFAULT_BASE_SDK "13.5"

#define BP_DEFAULT_DEVICE_TYPE "iPhone 8"

Expand Down