Small cleanups pre 12.5 #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting this error when running locally: Failed to open macho file at /usr/bin/nm for reading: Too many levels of symbolic links and it only happens with the `popen()` for swift. Since we use runShell for objective C right below, make the calls match. Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Remove unneeded headers Clean up the interfaces to BPTestBundleConnection and BPTestDaemonConnection Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
ob
force-pushed
the
ob/small-cleanup-pre-12.5
branch
from
9468b9f
to
95e469d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small clean-up so that #491 is smaller.
It just removes some unnecessary imports, and replaces a call to
popen()withNSTask