Xcode 12.5 support #491
Merged
Xcode 12.5 support #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shepting
reviewed
May 21, 2021
| - name: Select Xcode 12.4 | ||
| run: sudo xcode-select -s /Applications/Xcode_12.4.app | ||
| - name: Select Xcode 12.5 | ||
| run: sudo xcode-select -s /Applications/Xcode_12.5.app |
* Added an Architecture doc Signed-off-by: Buzz-Lightyear <m.srinivas1729@gmail.com> Co-authored-by: Oscar Bonilla <6f6231@gmail.com>
Merged
* Remove call to popen() and use runShell I was getting this error when running locally: Failed to open macho file at /usr/bin/nm for reading: Too many levels of symbolic links and it only happens with the `popen()` for swift. Since we use runShell for objective C right below, make the calls match. Signed-off-by: Oscar Bonilla <6f6231@gmail.com> * Some cleanups Remove unneeded headers Clean up the interfaces to BPTestBundleConnection and BPTestDaemonConnection Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
One way XCTest differentiates between Swift and Objective-C tests is by the parenthesis at the end of the name. I can't remember why we were stripping them, but I suspect it was for aesthetic reasons. Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Although the previous comment said testsToRun didn't work and testsToSkip did, through experiementation it seems that the opposite is true in Xcode 12.5.
Turns out that macos-latest maps to 10.5 which doesn't support Xcode 12.5, but if you use macos-11 you can get Xcode 12.5.
This reverts commit df78494. This is the wrong fix, the problem is not that testsToSkip doesn't work, the problem is that we are not differentiating between Objective-C and Swift tests.
Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
…xcode-12.5 Signed-off-by: Oscar Bonilla <6f6231@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #490 in order to fix #488. What is in this PR:
macOS-latestimage, which is macOS 10.5. Themacos-11pool does have Xcode 12.5, but it's not available due to this issue.XCTTestIdentifierhandling is wrong because it turns Swift tests into Objective-C tests sotestsToRunandtestsToSkipdon't work. SeeBPTestCasedoesn't keep track of which tests are Objective-C and which are Swift #492 for more details. PR: Keep parenthesis in Swift tests #496Need to plug in the newXCTCapabilitiesstuff in the protocols.