Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function name typo in warning message #274

Merged
merged 1 commit into from
Apr 10, 2022

Conversation

a2
Copy link
Contributor

@a2 a2 commented Apr 9, 2022

I saw this warning locally while working on my patch in bazelbuild/rules_apple. Basically the warning calls the function rules_xcodeproj_dependencies whereas the function's name is xcodeproj_rules_dependencies.

@brentleyjones
Copy link
Contributor

Thanks!

It's the function that has the wrong name though 😅

@a2
Copy link
Contributor Author

a2 commented Apr 10, 2022

Oh no! Okay, is there a concern that fixing the function's name could break in clients' code?

@brentleyjones
Copy link
Contributor

Not really, as we are pre-1.0, so there will be breaking changes. We will call it out in the release notes.

Copy link
Contributor

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it seems that the other repos follow this pattern as well. Let's keep it named this way. I'll accept this change as is.

Thanks again!

@brentleyjones brentleyjones merged commit 5343670 into MobileNativeFoundation:main Apr 10, 2022
@a2 a2 deleted the patch-1 branch April 10, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants