Parse user-provided copts for Swift #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalestraPatrick
force-pushed
the
pb/parse-user-provided-swift-copts
branch
from
da6e2eb
to
9669adc
Compare
brentleyjones
approved these changes
Apr 13, 2022
Co-authored-by: Brentley Jones <github@brentleyjones.com>
Co-authored-by: Brentley Jones <github@brentleyjones.com>
BalestraPatrick
force-pushed
the
pb/parse-user-provided-swift-copts
branch
from
5f23c5e
to
f44032a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where
coptsfor Swift code are not collected correctly and can cause build failures. Still very much a WIP, but feedback welcome!