Respect "Continue building after errors" setting #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dflems
changed the title
dflems
force-pushed
the
continue-after-errors
branch
from
e77645c
to
3901582
Compare
dflems
commented
Apr 29, 2024
xcodeproj/internal/bazel_integration_files/generate_bazel_dependencies.sh
Show resolved
Hide resolved
luispadron
reviewed
Apr 29, 2024
xcodeproj/internal/bazel_integration_files/generate_bazel_dependencies.sh
Show resolved
Hide resolved
brentleyjones
approved these changes
Apr 29, 2024
Signed-off-by: Dan Fleming <dan@dflems.com>
dflems
force-pushed
the
continue-after-errors
branch
from
3901582
to
fa8e51d
Compare
|
@brentleyjones Re-pushed with the signoff thing |
brentleyjones
approved these changes
Apr 29, 2024
luispadron
approved these changes
Apr 29, 2024
Signed-off-by: Dan Fleming <dan@dflems.com>
brentleyjones
approved these changes
Apr 29, 2024
|
Can someone help explain why the commit message style GH action is unhappy with how I worded my message? 😅 It looks like "respect" should be allowed? |
brentleyjones
merged commit a6640ca
into
MobileNativeFoundation:main
15 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
--keep_goingflag to builds when the "Continue building after errors" flag is set. Maybe there's a better place to add this, but I think it would be nice to respect the setting in the IDE.