Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect "Continue building after errors" setting #3020

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Respect "Continue building after errors" setting #3020

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa8e51d
Respect "Continue building after errors" setting
dflems Apr 29, 2024
f20400f
Add --nokeep_going when continue building flag is unset
dflems Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions xcodeproj/internal/bazel_integration_files/generate_bazel_dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,12 @@ else
readonly config="_${BAZEL_CONFIG}_build"
fi

# Respect the "Continue building after errors" setting
continue_building_value="$(defaults read com.apple.dt.Xcode IDEBuildingContinueBuildingAfterErrors 2>/dev/null)"
if [ "$continue_building_value" == "1" ]; then
build_pre_config_flags+=("--keep_going")
dflems marked this conversation as resolved.
Show resolved Hide resolved
fi

brentleyjones marked this conversation as resolved.
Show resolved Hide resolved
# Runtime Sanitizers
if [[ $apply_sanitizers -eq 1 ]]; then
if [ "${ENABLE_ADDRESS_SANITIZER:-}" == "YES" ]; then
Expand Down
Loading