Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collect all test reports #1030

Merged
merged 3 commits into from Oct 6, 2021
Merged

fix: collect all test reports #1030

merged 3 commits into from Oct 6, 2021

Conversation

lionel-nj
Copy link
Contributor

@lionel-nj lionel-nj commented Oct 6, 2021

Summary:

Please review #1031 first.

This PR provides support to fix #1029. This PR updates the gradle task that is dedicated to test report generation and aggregation.

Expected behavior:

Test reports should be generated and persisted in github action checks.
Capture d’écran, le 2021-10-06 à 14 10 09

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@lionel-nj lionel-nj merged commit 6982543 into master Oct 6, 2021
@lionel-nj lionel-nj deleted the fix/collect-test-reports branch October 6, 2021 19:05
@lionel-nj
Copy link
Contributor Author

Thanks for the review @maximearmstrong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test reports are not generated
2 participants