-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generate errors when missing lat/long for stops, stations, entrances #1321
fix: generate errors when missing lat/long for stops, stations, entrances #1321
Conversation
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopLatLongValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopLatLongValidator.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/StopLatLongValidator.java
Outdated
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/validator/StopLatLongValidatorTest.java
Outdated
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/validator/StopLatLongValidatorTest.java
Outdated
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/validator/StopLatLongValidatorTest.java
Outdated
Show resolved
Hide resolved
@bdferris-v2 I believe all your suggestions are now implemented, thanks for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@briandonahue one other issue: I think the code formatting check is failing on your PR. Can you run the Gradle |
@briandonahue and @bdferris-v2 sorry to arrive late on this PR, the documentation is missing for this new notice. Also, I acknowledge that a review by a core developer is enough to unblock the merge (thank you @bdferris-v2), but please wait for a MobilityData staff to review as well before merging. I know our capacity doesn't allow us to review right away, but we need to acknowledge what has been merged on this project so that we can:
|
…nces (MobilityData#1321) * Add validation and test for missing lat/lon on Stops, Stations, Entrances * Rename validator for clarity and differentiation of generated validator * inline builder for readability * rename notice class for consistency * use static import * Remove unnecessary comment * formatting
…nces (MobilityData#1321) * Add validation and test for missing lat/lon on Stops, Stations, Entrances * Rename validator for clarity and differentiation of generated validator * inline builder for readability * rename notice class for consistency * use static import * Remove unnecessary comment * formatting
…nces (MobilityData#1321) * Add validation and test for missing lat/lon on Stops, Stations, Entrances * Rename validator for clarity and differentiation of generated validator * inline builder for readability * rename notice class for consistency * use static import * Remove unnecessary comment * formatting
Summary:
Generate error notice when Latitude and/or Longitude is not supplied for stops (location_type=0), stations (location_type=1) or entrances/exits (location_type=2).
Addresses #1180
Expected behavior:
Should throw an error when missing geocoordinate data for stops, stations, entrances/exits
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything