Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate errors when missing lat/long for stops, stations, entrances #1321

Merged

Conversation

briandonahue
Copy link
Collaborator

Summary:

Generate error notice when Latitude and/or Longitude is not supplied for stops (location_type=0), stations (location_type=1) or entrances/exits (location_type=2).

Addresses #1180

Expected behavior:

Should throw an error when missing geocoordinate data for stops, stations, entrances/exits

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s) (N/A)

@briandonahue briandonahue changed the title Add validation and test for missing lat/lon on Stops, Stations, Entra… fix: generate errors when missing lat/long for stops, stations, entrances Feb 1, 2023
@briandonahue
Copy link
Collaborator Author

@bdferris-v2 I believe all your suggestions are now implemented, thanks for reviewing!

Copy link
Collaborator

@bdferris-v2 bdferris-v2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdferris-v2
Copy link
Collaborator

@briandonahue one other issue: I think the code formatting check is failing on your PR. Can you run the Gradle goJF command on your code to format it properly and update the PR? Thanks!

@isabelle-dr
Copy link
Contributor

@briandonahue and @bdferris-v2 sorry to arrive late on this PR, the documentation is missing for this new notice.
I know we are discussing generating RULES.md automatically, but in the meantime, we need it 😊.
The HTML report links directly to RULES.md to tell users what the notice is, and how to fix it.

Also, I acknowledge that a review by a core developer is enough to unblock the merge (thank you @bdferris-v2), but please wait for a MobilityData staff to review as well before merging. I know our capacity doesn't allow us to review right away, but we need to acknowledge what has been merged on this project so that we can:

KClough pushed a commit to JarvusInnovations/gtfs-validator that referenced this pull request Feb 24, 2023
…nces (MobilityData#1321)

* Add validation and test for missing lat/lon on Stops, Stations, Entrances

* Rename validator for clarity and differentiation of generated validator

* inline builder for readability

* rename notice class for consistency

* use static import

* Remove unnecessary comment

* formatting
KClough pushed a commit to JarvusInnovations/gtfs-validator that referenced this pull request Mar 1, 2023
…nces (MobilityData#1321)

* Add validation and test for missing lat/lon on Stops, Stations, Entrances

* Rename validator for clarity and differentiation of generated validator

* inline builder for readability

* rename notice class for consistency

* use static import

* Remove unnecessary comment

* formatting
ryon pushed a commit to JarvusInnovations/gtfs-validator that referenced this pull request Apr 1, 2023
…nces (MobilityData#1321)

* Add validation and test for missing lat/lon on Stops, Stations, Entrances

* Rename validator for clarity and differentiation of generated validator

* inline builder for readability

* rename notice class for consistency

* use static import

* Remove unnecessary comment

* formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants