fix: update RULES.md with missing rule #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdferris-v2
reviewed
Feb 10, 2023
bdferris-v2
reviewed
Feb 11, 2023
3 tasks
isabelle-dr
approved these changes
Feb 14, 2023
Co-authored-by: isabelle-dr <isabelle@mobilitydata.org>
Co-authored-by: isabelle-dr <isabelle@mobilitydata.org>
fredericsimard
approved these changes
Feb 15, 2023
|
@fredericsimard I don't think it's enough for you to approve this PR. I believe you have to be the one to merge it as well. |
|
@bdferris-v2 I didn't know what the last step was, hence why I didn't merge it:
|
KClough
pushed a commit
to JarvusInnovations/gtfs-validator
that referenced
this pull request
Feb 24, 2023
* Rules.md udpate * alignment tweaks * Update RULES.md Co-authored-by: isabelle-dr <isabelle@mobilitydata.org> * Update RULES.md Co-authored-by: isabelle-dr <isabelle@mobilitydata.org> --------- Co-authored-by: isabelle-dr <isabelle@mobilitydata.org>
KClough
pushed a commit
to JarvusInnovations/gtfs-validator
that referenced
this pull request
Mar 1, 2023
* Rules.md udpate * alignment tweaks * Update RULES.md Co-authored-by: isabelle-dr <isabelle@mobilitydata.org> * Update RULES.md Co-authored-by: isabelle-dr <isabelle@mobilitydata.org> --------- Co-authored-by: isabelle-dr <isabelle@mobilitydata.org>
ryon
pushed a commit
to JarvusInnovations/gtfs-validator
that referenced
this pull request
Apr 1, 2023
* Rules.md udpate * alignment tweaks * Update RULES.md Co-authored-by: isabelle-dr <isabelle@mobilitydata.org> * Update RULES.md Co-authored-by: isabelle-dr <isabelle@mobilitydata.org> --------- Co-authored-by: isabelle-dr <isabelle@mobilitydata.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1329. Missing rule definition from PR #1321
Expected behavior:
Rule should have been added to RULES.md
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything