Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Sentry Error Monitoring to web validator client + service #1384

Merged
merged 14 commits into from
Apr 18, 2023

Conversation

KClough
Copy link
Collaborator

@KClough KClough commented Apr 7, 2023

Summary:

Resolves #1373

Expected behavior:

Unhandled errors will be captured via Sentry.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

ryon and others added 9 commits April 1, 2023 06:02
* refactor migration file

* update documentation with new file

* fix wording

* Make easier to read

* remove colors

---------

Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com>
* Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing.  In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds.

* Additional unit tests for ValidationReportComparator.
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: afef5b3
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: 13ad05d
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@KClough KClough marked this pull request as ready for review April 8, 2023 21:55
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: 29cec9e
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sentry endpoint should not be set in the repository. We can inject the file or replace its content in the deployment process to be available at runtime.

web/client/src/routes/+page.svelte Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: 375e53e
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@KClough KClough requested a review from davidgamez April 16, 2023 20:16
@isabelle-dr
Copy link
Contributor

Is this ready to merge ? 😃

@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1425 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1425 sources (~0 %) are corrupted.
Commit: 0d1295a
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@KClough KClough merged commit bc96524 into master Apr 18, 2023
333 checks passed
@KClough KClough deleted the feat/web-client-sentry branch April 18, 2023 18:56
bradyhunsaker pushed a commit to bradyhunsaker/gtfs-validator that referenced this pull request Apr 25, 2023
…obilityData#1384)

* chore: fix deprecated dependency

* chore: auto-format

* feat: handle missing RULES.md

* feat: refactor upload process and handle more errors

* Add a more descriptive test failure message to NoticeFieldsTest. (MobilityData#1369)

* Docs: Update notice migration file (MobilityData#1357)

* refactor migration file

* update documentation with new file

* fix wording

* Make easier to read

* remove colors

---------

Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com>

* feat: Fail acceptance tests on significant change in warnings (MobilityData#1377)

* Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing.  In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds.

* Additional unit tests for ValidationReportComparator.

* Add sentry script to static html header

* Add sentry script to web service

* Remove sentry properties from source control

---------

Co-authored-by: Ryon Coleman <ryon55@gmail.com>
Co-authored-by: Brian Ferris <bdferris+v2@google.com>
Co-authored-by: isabelle-dr <isabelle@mobilitydata.org>
Co-authored-by: Emma Blue <90632321+emmambd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Validator: Add Sentry to Service + Client to capture errors
5 participants