Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update ACCEPTANCE_TESTS.md #1385

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Docs: Update ACCEPTANCE_TESTS.md #1385

merged 2 commits into from
Apr 13, 2023

Conversation

isabelle-dr
Copy link
Contributor

Summary:
Update our doc after the addition of warning and info to the test. Closes #1349

Expected behavior:

The doc matches with the tests

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [ ] Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • [ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)

After the addition of warning and info to the test
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isabelle-dr isabelle-dr merged commit 6439b6b into master Apr 13, 2023
13 checks passed
@isabelle-dr isabelle-dr deleted the issue1349-doc-update branch April 13, 2023 20:35
bradyhunsaker pushed a commit to bradyhunsaker/gtfs-validator that referenced this pull request Apr 25, 2023
After the addition of warning and info to the test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acceptance Tests only report changes in ERROR notices, not WARNINGS or INFOs
2 participants