Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Report, limit records displayed #1433

Merged
merged 30 commits into from
May 25, 2023

Conversation

briandonahue
Copy link
Collaborator

Summary:

Closes #1306. The HTML report is not functioning well when large amounts of records are flagged for one or more notices.

We will limit the number of displayed records to a sample of 100, which does not cause performance errors. The full list is still available in the JSON report.

Expected behavior:

Accordion sections should still open/close and display sample records.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@briandonahue briandonahue force-pushed the issue/1306/bug-large-html-reports branch from efebe96 to 0b071ff Compare May 4, 2023 14:45
@briandonahue
Copy link
Collaborator Author

@isabelle-dr @davidgamez This was added onto the #1389, the metadata PR, so is marked as draft until that PR is merged. Here is an example of the message added when # of affected records > 100:
image

@isabelle-dr
Copy link
Contributor

Great :)

@isabelle-dr isabelle-dr linked an issue May 23, 2023 that may be closed by this pull request
Base automatically changed from issues/1363/report-metadata to master May 24, 2023 13:03
@isabelle-dr
Copy link
Contributor

@briandonahue now that #1389 is merged, this one is ready for review right?

@briandonahue briandonahue force-pushed the issue/1306/bug-large-html-reports branch from 2422f8c to 7ffb08f Compare May 24, 2023 14:24
@briandonahue
Copy link
Collaborator Author

@briandonahue now that #1389 is merged, this one is ready for review right?

@isabelle-dr Had to fix some conflicts, it should be good now, though!

@briandonahue
Copy link
Collaborator Author

Screenshot example:
image

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@briandonahue briandonahue marked this pull request as ready for review May 24, 2023 14:28
@github-actions
Copy link
Contributor

✅ Rule acceptance tests passed.
New Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1428 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1428 sources (~0 %) are corrupted.
Commit: d95243a
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

@isabelle-dr
Copy link
Contributor

Merging then :)

Thank you @briandonahue for this contribution!

@isabelle-dr isabelle-dr merged commit c84eaa4 into master May 25, 2023
333 checks passed
@isabelle-dr isabelle-dr deleted the issue/1306/bug-large-html-reports branch May 25, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The HTML file doesn't work on large reports
4 participants