-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add notice descriptions to HTML report #1447
Conversation
This reverts commit c89c716.
✅ Rule acceptance tests passed. |
cbc03ad
to
40e6c8c
Compare
✅ Rule acceptance tests passed. |
@davidgamez @isabelle-dr Since #1433 has been merged, this one is now ready for review! |
The column descriptions are such a nice addition :) |
✅ Rule acceptance tests passed. |
@isabelle-dr done! |
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
Summary:
Closes #1364. This PR depends on #1433 being merged first, so is initially submitted as a draft PR.
Add notice descriptions for each notice to the HTML report. Converts markdown comment to HTML.
Expected behavior:
Should include the specific description for each notice in the report
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anythingAttached are zip files output for 2 different reports. View the
report.html
in your browser after unzipping.alhambra.zip
westchester.zip