feat: Validate how locations are referenced from stop_times.stop_id #960
Conversation
* every stop (or platform) should have stop times * every non-stop location (station, entrance etc) may not have stop times We produce one notice per location to avoid producing too many notices.
|
I am not updating NOTICES.md since we plan to dissolve/remove this file. |
|
This PR is open-sourcing a validator rule used at Google. |
|
Closing and reopening to apply the workflow defined in #953 that aims at checking code formatting. |
There was a problem hiding this comment.
Thanks @aababilov, one question: how are boarding areas treated? From #961 it seems that a boarding area should be allowed to have stop_times only if its parent station has location_type=0, if it is not the case then it should not. If said boarding area qualifies to have stop_times, then it should be used.
@barbeau thoughts?
|
This is a good question! Our current spec for stop_times.stop_id says: Referenced locations must be stops/platforms, i.e. their stops.location_type value must be 0 or empty. So, boarding areas may not be referenced from stop_times. |
|
Makes senses @aababilov! Thanks for working on that. Could you fix this please, and then we'll be good to merge. |
We produce one notice per location to avoid producing too many notices.